-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle backend errors in pool page #1031
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Gareth Fuller <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agualis I'm struggling to get this to work how I wanted with Error boundaries. It works in dev, but in production it blocks you from rendering error messages that are thrown in server components for security reasons, which makes sense.
I need to move on to something else for now, maybe you could take another look. Maybe you were right to start with by just rendering an error message on the RSC.
* fix: pool page error when pool id is not found * fix: avoid alert var * fix: capture pool query backend errors in sentry * Update app/(app)/pools/[chain]/[variant]/[id]/layout.tsx Co-authored-by: Gareth Fuller <[email protected]> * Update app/(app)/pools/[chain]/[variant]/[id]/layout.tsx Co-authored-by: Gareth Fuller <[email protected]> * chore: Use error boundaries * chore: Minor updates * chore: Remove * chore: Handle errors better * chore: Update container height * fix: Await header --------- Co-authored-by: Gareth Fuller <[email protected]>
Before this fix any backend error in a pool query would crash the app and send an error to sentry.
After this fix: